pyomeca / ezc3d

Easy to use C3D reader/writer for C++, Python and Matlab
https://pyomeca.github.io/Documentation/ezc3d/index.html
MIT License
145 stars 46 forks source link

Re-solves #264 #283

Closed felixchenier closed 1 year ago

felixchenier commented 1 year ago

This re-solves #264 which had been cancelled by commit ba50ee55aa1a4fcceb87460ec07fc03c3fc5365b

This is important if you need to support non-integer sample rates. Currently, the only way to make ezc3d to write analogs and points reliably is to specifically define the sampling rates as integers. Floats don't work.

While using floats for sampling rate may be weird (normally we set it as an int in the recording software), I can see value to support floats, for instance to synchronize two instruments that drifted over a common sampling rate that could be non-integer.

In my particular application (ktk), I need to generate c3ds from TimeSeries where the sampling rate is calculated dynamically based on a time vector. It will always be a float.

Anyway this PR fixes it.


This change is Reviewable