pyomeca / ezc3d

Easy to use C3D reader/writer for C++, Python and Matlab
https://pyomeca.github.io/Documentation/ezc3d/index.html
MIT License
145 stars 46 forks source link

Bug: Reading analogs from .c3d using Kineticstoolkit via ezc3d #307

Closed zybermonk closed 9 months ago

zybermonk commented 10 months ago

I have some .c3d files recorded from a Mocap system. I use kineticstoolkit library (which in-turn uses ezc3d to read files), but it does not read the analogs from these c3d files by default. However, When I open the files in a biomechanics viewer (mokka) analogs are present. And when I export the exact file from mokka, now ktk (kineticstoolkit) reads the analogs.

Please refer to this issue on kineticstoolkit for more information: https://github.com/kineticstoolkit/kineticstoolkit/issues/219

Talking to KTK, the issue seems to be on the ezc3d. Any assistance would be appreciated. Additionally, if you need the files before and after exporting from mokka, I can share them with you via email.

Thanks in advance. Regards.

pariterre commented 10 months ago

Hi @zybermonk

Thanks for reporting the issue, could you provide me with a faulting C3D so I can have a look a the issue

Regards :)

zybermonk commented 10 months ago

Hi @pariterre, Thank you for your quick response. I have sent them to your mail that I got from your GitHub.

Looking forward to your response. Best, Mohan

pariterre commented 10 months ago

Hi @zybermonk still waiting for the c3d file!

zybermonk commented 10 months ago

Hi @pariterre, I sent it to pariterre@hotmail.com, right after your request. Please check your spam just in case it ended up there.

Alternatively, if you want it to an other address, I shall share them again. Let me know. Thanks

pariterre commented 10 months ago

It does not seem to be in the spam... could you try same address but gmail.com?

zybermonk commented 10 months ago

Done. Let me know if you received them in your gmail.

pariterre commented 10 months ago

Yep, got it :)

pariterre commented 9 months ago

Dear @zybermonk Sorry for the late answer, I could have a look at the data. It seems Shadow was quite loose in their implementation of the C3D format... I made a fix that overcome this. If you are able to compile ezc3d by yourself, could you have a try? If not, I can make a release which will allow you to download the latest version, but I am not 100% sure of the fix, that's why I'd like you input on: does this fix gives expected results!

pariterre commented 9 months ago

See #309

zybermonk commented 9 months ago

Dear @zybermonk Sorry for the late answer, I could have a look at the data. It seems Shadow was quite loose in their implementation of the C3D format... I made a fix that overcome this. If you are able to compile ezc3d by yourself, could you have a try? If not, I can make a release which will allow you to download the latest version, but I am not 100% sure of the fix, that's why I'd like you input on: does this fix gives expected results!

Thank you, @pariterre, The fix seems to work and is getting us the required analogs. Really appreciate the workaround to overcome this.

Closing the issue as done.