search

pyoncord / Bunny

A client mod for Discord mobile, fork of Vendetta
BSD 3-Clause "New" or "Revised" License
1.44k stars 35 forks source link

change: Error boundary colours #96

Open Moodzz1 opened 4 hours ago

Moodzz1 commented 4 hours ago

Describe the change It's for the new crash screen merged from dev

The outer background is BACKGROUND_PRIMARY The inner background is BG_BASE_PRIMARY

I am requesting for the outer background to be changed to BG_BASE_SECONDARY and inner background to CARD_PRIMARY_BG

BG_BASE_SECONDARY - outer background for settings pages CARD_PRIMARY_BG - plugin/theme cards This change is a very small and probably dumb one but for the sake of consistency and theming purposes it would genuinely help.

pylixonly commented 2 hours ago

The outer background is BACKGROUND_PRIMARY

Use of BACKGROUND_PRIMARY is retained from Vendetta: https://github.com/vendetta-mod/Vendetta/blob/rewrite/src/ui/safeMode.tsx#L18-L22 How could the change affect the consistency? Is this something recently affected or it has been a while? And why should it be BG_BASE_SECONDARY?

CARD_PRIMARY_BG - plugin/theme cards

The colors of these cards are decided by Discord itself, I'm can't see how it could be inconsistent and trying to change this color would be hacky somewhat. Do they differ from Discord's use?