Provide a name when operationId is missing

dasevilla commented 8 years ago

The specification says that operationId is optional. When this happens, generate a unique name using the HTTP method and path.

Prior to this patch, all operations without an operationId were silently omitted.

This patch is related to #42

coveralls commented 8 years ago

Coverage increased (+0.008%) to 94.215% when pulling 129486c315fc680451c4b1ceec9aed43b42f6cc0 on dasevilla:missing-operationId into 4073c87fc78d46443dc3f9303af1e57ca14f29dc on mission-liao:master.

mission-liao commented 8 years ago

Hi, I'm very appreciated with your contribution. Here is my suggestion before accepting it as main branch:

I understand this behavior is very convenient for API users, however, it's dropped by OpenAPI when its SPEC upgrading from 1.2 to 2.0. So I prefer to put this behavior in a separated scanner. Simply replace your new scanner to /pyswagger/contrib/scanner/, make it selectable, and keep the original one as default.
help to write a test for your new scanner, you can make a dedicated, simplified swagger.json, or just use the bitbucket one(/pyswagger/tests/data/v2_0/bitbucket, they don't provide operationId in their definition).

If you have comments of these suggestion, please feel free to let me know.

dasevilla commented 8 years ago

How would I use this custom scanner?

mission-liao commented 8 years ago

I just realize that I didn't provide a sample to use scanner. Here is one when I tried to answer other issues.

https://github.com/mission-liao/pyswagger/issues/66#issuecomment-178988166

pyopenapi / pyswagger

Provide a name when operationId is missing #85