Suggest if can consider using Sourcery to improve code quality

pyoscx / scenariogeneration

Python library to generate linked OpenDRIVE and OpenSCENARIO files

Mozilla Public License 2.0

256 stars 81 forks source link

Suggest if can consider using Sourcery to improve code quality #215

Closed dongfeng2134 closed 1 month ago

dongfeng2134 commented 5 months ago

Just one line of instructions sourcery review --fix .

dongfeng2134 commented 5 months ago

Or I can provide a pull request

MandolinMicke commented 5 months ago

Haha, not surprised about the ifs :P So many long ifs in the xodr module. Some places I sadly think the code will be very hard to read (especially in xodr) since there are so many different cases all the time.

But give it a try :)

dongfeng2134 commented 5 months ago

https://github.com/pyoscx/scenariogeneration/pull/220