search

pypa / auditwheel

Auditing and relabeling cross-distribution Linux wheels.
Other
432 stars 142 forks source link

fix: don't create empty .libs directory #489

Closed trim21 closed 3 months ago

trim21 commented 3 months ago

close https://github.com/pypa/auditwheel/issues/488

only create ${package}.libs when needed

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.94%. Comparing base (e969b7b) to head (760b3f3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #489 +/- ## ========================================== + Coverage 91.87% 91.94% +0.07% ========================================== Files 20 20 Lines 1267 1266 -1 Branches 279 279 ========================================== Hits 1164 1164 Misses 57 57 + Partials 46 45 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mayeut commented 3 months ago

Thanks for your contribution, would you be able to add a test case for this as well (in tests/integration/test_manylinux.py:AnyLinux, the testsimple project can be used for the new test as it has no external dependency) ?