search

pypa / bandersnatch

A PyPI mirror client according to PEP 381 http://www.python.org/dev/peps/pep-0381/
Academic Free License v3.0
448 stars 141 forks source link

feat: allow using a non-https mirror via config #1765

Closed miketheman closed 3 months ago

miketheman commented 3 months ago

Resolves #1759

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.50%. Comparing base (4d020e8) to head (ec44821). Report is 123 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1765 +/- ## ========================================== + Coverage 79.69% 83.50% +3.80% ========================================== Files 31 33 +2 Lines 4324 4383 +59 Branches 780 783 +3 ========================================== + Hits 3446 3660 +214 + Misses 721 535 -186 - Partials 157 188 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

miketheman commented 3 months ago

All looks good to me, but i don't see the need of None for the param. Please correct me if I've missed something.

Hate being nit-picky but feel we don't need it to be 'optional' here ...

Thanks for calling that out, making it explicit removes the need for a fallback/Optional

cooperlees commented 3 months ago

I did think we could add the fallback to == False itself so the param can be left out of configs. I don't want people to really know about this config parameter. I'll test later and if so add it in.