search

pypa / browntruck

6 stars 20 forks source link

Browntruck has been moved from pip-committers to pip-helpers team #23

Closed xavfernandez closed 4 years ago

xavfernandez commented 4 years ago

Since it only needs to write comments & apply labels, it should be enough but if anything breaks in the next 24 hours it might come from this change :)

(and this issue can be closed otherwise in the following days)

pradyunsg commented 4 years ago

I'll take a look on the Heroku app tomorrow. I doubt anything would break.

chrahunt commented 4 years ago

Browntruck is leaving a lot of comments on pypa/pip#7188.

xavfernandez commented 4 years ago

Have added back BrownTruck to the pip-commiters teams. Hopefully, it will stop its comment frenzy.

@pradyunsg if you have access to bot logs, could you take a look ?

pradyunsg commented 4 years ago

sigh

The bot was failing to put the label, which is how it maintains state for this.

I'm not sure why that was happening -- I don't see the logs, since this bot is very noisy in its logs as well, and prints too many lines (heroku trims logs at 1500 lines).

I think that I can pull that bot down, since it's not really adding any functionality over pypa-bot (pypa-bot is also supposed to be able to do PR checks).

I'll try to make some time to clean up our bot situation.

pradyunsg commented 4 years ago

@xavfernandez @pfmoore If you could make me a pypa admin, I can try debugging this thing by moving the bot around myself.

Or anything that lets me add/remove the bot from pypa/pip teams.

pfmoore commented 4 years ago

Or anything that lets me add/remove the bot from pypa/pip teams.

I didn't know any way of just doing this, so I made you a pypa owner

It looks like there are very few pypa owners, and I don't know if there's any formal method for adding new owners. I see no reason not to add you, so I've done so, but @di @dstufft @ewdurbin @jaraco if any of you have any reservations about me adding @pradyunsg as an owner, please speak up.

xavfernandez commented 4 years ago

I didn't know any way of just doing this, so I made you a pypa owner

You could have made him a maintainer of the pip-commiters team :) (select an user in https://github.com/orgs/pypa/teams/pip-committers/members and click the 1 member selected button to access Change role..., not the most intuitive UI)

But no problem with having Pradyun as admin.

pfmoore commented 4 years ago

You could have made him a maintainer of the pip-commiters team :)

Er, surely he is already? Or did you mean I could add the bot to that team?

xavfernandez commented 4 years ago

Er, surely he is already? Or did you mean I could add the bot to that team?

I'd say he was only a member of the team (like Matt, Daniel, Chris & Christopher) and not a maintainer (with the right to add/remove people from the team) but that's not really important ^^

xavfernandez commented 4 years ago

I think that I can pull that bot down, since it's not really adding any functionality over pypa-bot (pypa-bot is also supposed to be able to do PR checks).

Apparently, Browntruck checks the news file and the merge status of PR. It's however unclear what pypa-bot does ? But it would certainly be clearer to have a single bot.

pradyunsg commented 4 years ago

pypa-bot's sources are in the twisted branch.

pradyunsg commented 4 years ago

I now have the commit bit for both these bots, as well as access to both the deployments.

I'll make time Q1 2020, to figure out what to do with these bots. :)

pradyunsg commented 4 years ago

This should be fixed, now that it's a separate dedicated team for pip's bots.