search

pypa / cibuildwheel

🎡 Build Python wheels for all the platforms with minimal configuration.
https://cibuildwheel.pypa.io
Other
1.83k stars 234 forks source link

Check CI coverage for Python versions #1480

Open joerick opened 1 year ago

joerick commented 1 year ago

Let's figure out why we didn't catch #1478 in CI. Creating an issue to ensure we don't forget!

joerick commented 1 year ago

I looks like Travis scripts only worry about the last command for the error code. https://github.com/travis-ci/travis-ci/issues/1066 .

https://github.com/pypa/cibuildwheel/blob/5e15bb25b428e1bf2daf2215f173d2b40135f56f/.travis.yml#L55-L62

A set -o errexit should do the trick. I wonder if that will work on Windows too, do they run a POSIX shell on all platforms?

mayeut commented 2 months ago

this is still an issue on TravisCI as the tests are failing but the workflow isn't...