pypa / cibuildwheel

🎡 Build Python wheels for all the platforms with minimal configuration.
https://cibuildwheel.pypa.io
Other
1.78k stars 227 forks source link

feat: free-threaded Python for macOS, MACOSX_DEPLOYMENT_TARGET updates #1854

Closed cibuildwheel-bot[bot] closed 3 weeks ago

cibuildwheel-bot[bot] commented 3 weeks ago

Update the versions of our dependencies.

PR generated by "Update dependencies" workflow.

Close #1855.

henryiii commented 3 weeks ago

@mattip Do you know what the min macOS version is for pypy3.8? It looks like the last pypy3.7 supported 10.9: https://github.com/pypy/pypy/blob/cd05c8669313d29d531e2a74b63756467cf23bf9/pypy/doc/release-v7.3.8.rst#L137. But https://www.pypy.org/download.html seems to indicate 10.15 is now the minimum, so is it 10.9 for 3.7 and 3.8 and 10.15 now? I'm asking because CPython just moved from 10.9 to 10.13 as the minimum version with 3.13, so I'm looking at updating these minimums. (CPython puts 11 in the file name for ARM reasons, but it's actually 10.9 and now 10.13).

mattip commented 3 weeks ago

Please drop support for pyyp3.7, pypy3.8 as soon as possible, they are unsupported.

3,7, 3.8 sets MACOSX_DEPLOYMENT_TARGET to 10.9

3.9, 3.10 on macos-x86_64 should use minimum 10.15, due to https://github.com/pypy/pypy/issues/3879. But I see the sysconfig MACOS_DEPLOYMENT_TARGET in those is 10.13, which is wrong. I opened https://github.com/pypy/pypy/issues/4975 to fix this going forward.

arm64 is of course 11.0 and up.

henryiii commented 3 weeks ago

@mayeut or @joerick or @Czaki, anyone want to provide a second set of eyes? I think this is ready. Two changes: updated for the free-threaded build using https://github.com/python/cpython/issues/120098 (fantastic resource, by the way), and adjusted the MACOSX_DEPLOYMENT_TARGET to match the various CPython and PyPy minimums; it is also now clamped, cibuildwheel will raise it if it's too low. This is helpful if someone has 10.x (x<13) set and tries to build 3.13 wheels.

henryiii commented 3 weeks ago

Okay to go in? Needs to go in before the next auto bump, or I'll have to revert it from my local checkout. ;)