Open MusicalNinjaDad opened 2 weeks ago
@mayeut , @henryiii - does this look like the right sort of approach for splitting out utils? I've detailed my thought patterns in the description and would welcome your insights.
IMHO, we don't need the first item. cibuildwheel is not a library so this module is internal.
I would move download
to files.py
I think the next step is correcting the imports so we can avoid import *
.
This is a first step towards #1857 designed to get feedback and validate the approach.
Considerations
from cibuildwheel.util import *
,from cibuildwheel.util import foo
orimport cibuildwheel.util
should not notice the change. This has driven the implementation ofutil/__init__.py
from util.submodule import bar
. To me it feels like it is more likely to find valid and obvious fracture plains with this approach. Also if something is worth an independent function then it most likely either expects reuse in multiple contexts, abstracts away something that doesn't belong in the original flow but belongs somewhere else, or both.Checks performed
E0611
(no-name-in-module) errorspytest unit_test
passesRelying on the pipeline to perform more extensive integration testing