search

pypa / cibuildwheel

🎡 Build Python wheels for all the platforms with minimal configuration.
https://cibuildwheel.pypa.io
Other
1.78k stars 227 forks source link

windows-latest MSVC compiler crashes #1875

Open elalish opened 2 weeks ago

elalish commented 2 weeks ago

Description

This Action worked fine for our last release a few months back on v2.16, but now fails 100% (only on Windows - still works fine on Linux and MacOS) on both v2.16 and v2.19. It's very helpfully giving us this:

Error: Command python D:\a\manifold\manifold/bindings/python/examples/run_all.py failed with code 3221225477.

Build log

https://github.com/elalish/manifold/actions/runs/9487313229/job/26143641015

CI config

https://github.com/elalish/manifold/blob/fixPyPI2/.github/workflows/build_wheels.yml

henryiii commented 2 weeks ago

Try windows-2019, just a hunch.

henryiii commented 2 weeks ago

(GitHub updated to MSVC v144 about 5-7 days ago and I've seen some things falling. The windows-2019 images don't have the new MSVC)

elalish commented 2 weeks ago

Excellent, thank you - looks like that fixed it! I'll keep an eye on this issue to see when we can return to windows-latest.