pypa / distlib

A low-level library which implements some Python packaging standards (PEPs) and which could be used by third-party packaging tools to achieve interoperability.
http://distlib.readthedocs.io/
Other
49 stars 38 forks source link

Use version comparison logic for python_full_version. #187

Closed apeschar closed 1 year ago

apeschar commented 1 year ago

Currently, markers such as these don't yield the expected result: (Example from black.)

tomli>=1.1.0; python_full_version < '3.11.0a7'

This PR ensures that version comparison logic is used for python_full_version, as well as for python_version.

codecov[bot] commented 1 year ago

Codecov Report

Base: 83.07% // Head: 83.07% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (1a3974a) compared to base (98b9b89). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #187 +/- ## ======================================= Coverage 83.07% 83.07% ======================================= Files 24 24 Lines 8866 8873 +7 Branches 1827 1740 -87 ======================================= + Hits 7365 7371 +6 - Misses 1152 1155 +3 + Partials 349 347 -2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `82.17% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pypa/distlib/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa) | Coverage Δ | | |---|---|---| | [distlib/markers.py](https://codecov.io/gh/pypa/distlib/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa#diff-ZGlzdGxpYi9tYXJrZXJzLnB5) | `94.80% <100.00%> (-2.50%)` | :arrow_down: | | [tests/test\_markers.py](https://codecov.io/gh/pypa/distlib/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa#diff-dGVzdHMvdGVzdF9tYXJrZXJzLnB5) | `100.00% <100.00%> (ø)` | | | [distlib/util.py](https://codecov.io/gh/pypa/distlib/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa#diff-ZGlzdGxpYi91dGlsLnB5) | `73.78% <0.00%> (-0.08%)` | :arrow_down: | | [distlib/wheel.py](https://codecov.io/gh/pypa/distlib/pull/187/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa#diff-ZGlzdGxpYi93aGVlbC5weQ==) | `80.50% <0.00%> (+0.26%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pypa)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.