search

pypa / flit

Simplified packaging of Python modules
https://flit.pypa.io/
BSD 3-Clause "New" or "Revised" License
2.14k stars 130 forks source link

Functionality to replace password in keyring store #113

Open takluyver opened 7 years ago

takluyver commented 7 years ago

If you have keyring installed, and no password in your .pypirc file, flit will prompt you for your password the first time you upload, and then store it with keyring and reuse it for future uploads. But if you type the password incorrectly, or you change your password on the server, flit will still try to reuse the password it has stored. You would have to use the platform UI, which is often unfamiliar, to find and change/remove the stored password.

glyph commented 7 years ago

Is there any irony in the fact that https://github.com/glyph/secretly was the first project I released using flit, a day after you filed this issue? :) (I did not read it at the time.)

takluyver commented 7 years ago

Ha! I'm flattered that you're using it :-)

melMass commented 10 months ago

Just commenting since I just struggled to find this myself on windows it's in the Credential Manager (Control Panel\All Control Panel Items\Credential Manager):

image

Aran-Fey commented 1 month ago

It's downright criminal that nothing has been done about this in 7 years. The error message you get from an invalid password is exceedingly unhelpful:

See https://pypi.org/help/#invalid-auth for more information. for url: https://upload.pypi.org/legacy/

It sends you down two rabbit holes that have nothing to do with your problem, instead of simply telling you "hey, the password was incorrect, please input the correct one:".

You could trivially solve this problem with a simple input(), but no, you instead force your users to research flit internals on google and if @melMass hadn't posted the solution for my operating system, I would still be googling this right now. Absolutely garbage-tier UX.

glyph commented 1 month ago

It's downright criminal that nothing has been done about this in 7 years

You're right, it is weird that you haven't submitted a PR yet. Why haven't you? I couldn't find one with a quick search, did you forget to open one to your branch where you've implemented this?

(To be clear: I am satirizing your post because this is an inappropriately aggressive tone to take with a volunteer project, and you are as much a possible volunteer as Thomas here. If it's important to you, submit a fix and advocate for its inclusion. If you think that this makes Flit inappropriate to use, it's perfectly fair to tell other people not to use it because volunteer projects are not above criticism. But yelling at the maintainers doesn't help anyone.)

Aran-Fey commented 1 month ago

Why haven't you?

Because that is a ridiculously inefficient way of getting things done. I have my own projects to work on, and I wouldn't expect my users to submit a PR for such a trivial change. Do you seriously think that developers should familiarize themselves with every code base that they have feature requests for? If the world worked like that, then every code base on the planet would be an absolute mess because it's mostly written by clueless people instead of a cohesive team that knows what it's doing.

If you think my tone was too aggressive, that's fair enough. But the "argument" that I should submit a PR is laughable.

takluyver commented 1 month ago

@glyph already pointed out that his post was satire to highlight the unreasonable tone you took. Of course you don't have to contribute, but you don't get to lecture other people on what they should spend their time doing. This is not a product, you are not a customer.

Aran-Fey commented 1 month ago

Can you point out where I told someone what they should spend their time doing?

I posted two things: facts and my opinion.

takluyver commented 1 month ago

The tone of your first post was pretty clear, and this attitude is not welcome. Please stop arguing - it's not going to achieve anything.