search

pypa / flit

Simplified packaging of Python modules
https://flit.pypa.io/
BSD 3-Clause "New" or "Revised" License
2.14k stars 130 forks source link

Support environments without pip #651

Open orsinium opened 1 year ago

orsinium commented 1 year ago

Before: use pip installed in the target environment.

After: If pip is available in the current environment, use it, pointing it to the target environment using the --python flag. Otherwise, if Python is not installed in the same environment as flit, fall back to the old behavior.

This change is inspired by rye. It allows to use flit with virtual environments created with --without-pip flag.

orsinium commented 1 year ago

Right. I broke tests because they mock pip in the target environment. Well, tell me if you like the change, and I'll take care of actualizing tests.

takluyver commented 7 months ago

Thanks, I think this makes sense, if people are going to rely on this new-ish pip feature to make virtualenvs without pip inside. Sorry it's taken me a while to look at it.

There's at least one more call to pip that should be changed in the same way:

https://github.com/pypa/flit/blob/6035005746ac1ee2f7952a9fd89431705ab0a5da/flit/install.py#L372

I think that's all, but please have a look yourself in case I've missed one.

Unfortunately I suspect this will be quite a pain for the tests, because as you spotted, we use the ability to point it to an arbitrary Python to mock out the installation command for the tests. If you get stuck with that, one way out might be to swap around the priority, e.g. doing target_python -m pip --version to check if it's installed in the target environment, and only using the pip --python option if not. :thinking: