nox -s generate gives the error "AttributeError: 'HTTPResponse' object has no attribute 'strict'"

pypa / get-pip

Helper scripts to install pip, in a Python installation that doesn't have it.

https://bootstrap.pypa.io/pip/

MIT License

738 stars 293 forks source link

nox -s generate gives the error "AttributeError: 'HTTPResponse' object has no attribute 'strict'" #190

Closed pfmoore closed 1 year ago

pfmoore commented 1 year ago

See https://github.com/ionrock/cachecontrol/issues/293

Pinning "urllib3<2" in the session.install of the generate session fixes the issue, but I've not created a PR adding this yet, as IMO it would be better if it's fixed in cachecontrol, and we only use this function at release time, so there's no great urgency.

sethmlarson commented 1 year ago

I believe this has been fixed upstream in CacheControl (which has moved under the PSF org): https://github.com/psf/cachecontrol/releases/tag/v0.13.1

pradyunsg commented 1 year ago

Let's close this out then.