search

pypa / gh-action-pypi-publish

The blessed :octocat: GitHub Action, for publishing your :package: distribution files to PyPI, the tokenless way: https://github.com/marketplace/actions/pypi-publish
https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
BSD 3-Clause "New" or "Revised" License
929 stars 87 forks source link

twine-upload: fix tense on password nudge #234

Closed woodruffw closed 5 months ago

woodruffw commented 6 months ago

This also makes the password case a hard error on pypi.org, since we know it's going to fail. But I'm happy to revert that if you'd prefer to display the error and let twine upload fail instead 🙂

Fixes #233

woodruffw commented 6 months ago

Interesting CI failure:

Traceback (most recent call last):
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/bin/flake8", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 375, in run
    self._run(argv)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 363, in _run
    self.initialize(argv)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 343, in initialize
    self.find_plugins(config_finder)
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/main/application.py", line 157, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 363, in __init__
    self.manager = PluginManager(
                   ^^^^^^^^^^^^^^
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 243, in __init__
    self._load_entrypoint_plugins()
  File "/pc/clone/j4q6-vGoRx-4pfB3AoYZNg/py_env-python3/lib/python3.12/site-packages/flake8/plugins/manager.py", line 261, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get'
webknjaz commented 6 months ago

@woodruffw that's because of the Python 3.11->3.12 bump in pre-commit.ci. I'll fix that separately, it's already on my radar.