Fix removed `importlib.resources.read_binary` in Python 3.13

pypa / installer

A low-level library for installing from a Python wheel distribution.

https://installer.readthedocs.io/

MIT License

126 stars 51 forks source link

Fix removed `importlib.resources.read_binary` in Python 3.13 #201

Closed edgarrmondragon closed 10 months ago

edgarrmondragon commented 10 months ago

Closes #132

edgarrmondragon commented 10 months ago

@pradyunsg this is ready for review 🙂

Secrus commented 10 months ago

Please clean up your PR. There are a lot of changes that don't seem to be related to what the title and linked issue mention (especially around pyproject.toml file).

edgarrmondragon commented 10 months ago

Please clean up your PR. There are a lot of changes that don't seem to be related to what the title and linked issue mention (especially around pyproject.toml file).

Thanks @Secrus. I've limited the diff to

noxfile.py: adds 3.12 and 3.13
workflow: updates the matrix and bumps actions/setup-python so we can use allow-prereleases

eli-schwartz commented 10 months ago

It's rather difficult to tell what you've limited to, or why you kept in the diffs you did, since they are divided up between 7 different commits that are mostly reverting previous commits.

:thinking: on the other hand it appears quite likely all context will be lost due to squash merging anyway.

Secrus commented 10 months ago

@edgarrmondragon thank you for your contribution. I would love to see other changes you previously made in this PR, so feel free to open PRs with those 😉