pypa / manylinux

Python wheels that work on any linux (almost)
MIT License
1.44k stars 218 forks source link

Include uv in tools? #1607

Closed henryiii closed 4 months ago

henryiii commented 5 months ago

I'd like to try uv for cibuildwheel, and it's a single binary that works across Python versions, so it seems like adding it here would be a good first step. Thoughts?

Also, uv already supports free-threaded builds since https://github.com/astral-sh/uv/pull/2805. :)

mayeut commented 5 months ago

How do you plan to install it on Windows/macOS ? I'd rather use pipx to install the binary (as it allows to track version changes easily without rewriting a specific update script) but this is not possible at the moment c.f. https://github.com/astral-sh/uv/issues/3439

While the issue is related to gnu aarch64, the same is true for musllinux_1_1 compatibility (but on all arch)

henryiii commented 4 months ago

I think this is fixed for the next release?

mayeut commented 4 months ago

I think this is fixed for the next release?

for gnu aarrch64, it seems to be but not for musllinux_1_1, I'll create an issue tomorrow.

henryiii commented 4 months ago

It looks like Rust doesn't support 32-bit musl with host tools (only without), and 64-bit musl is based on 1.2: https://doc.rust-lang.org/rustc/platform-support.html

henryiii commented 4 months ago

I'm working on the first part here: https://github.com/astral-sh/uv/pull/3523

It also needs the other archs. I notice muslllinux is completely missing from the readme, is that intentional?

mayeut commented 4 months ago

is that intentional?

no, this is #1192

henryiii commented 4 months ago

I'm not sure Rust has enough support for the special musl archs, see https://github.com/astral-sh/uv/pull/3537. Would it be acceptable to add it for everything but those? I expect they are very lightly used.

henryiii commented 4 months ago

uv muslllinux 1.1 wheels shipped. Only musllinux powerpc64le and s390x are missing now. Those are likely going to be tricky, though powerpcle64 might be the easier of the two.

henryiii commented 4 months ago

musl ppc64le was doable.