search

pypa / manylinux

Python wheels that work on any linux (almost)
MIT License
1.46k stars 219 forks source link

tk/tckl pkg-config broken on manylinux2014 #1718

Open mattip opened 14 hours ago

mattip commented 14 hours ago

PR #1365 added support for tk/tcl 8.6, and removes the static stub libraries. But using pkg-config still has the stub libraries in the link command

# pkg-config tcl --libs
-L/usr/local/lib -ltcl8.6 -ltclstub8.6

 pkg-config tk --libs
-L/usr/local/lib -ltk8.6 -ltkstub8.6 -ltcl8.6 -ltclstub8.6

I am not sure how the cpython build works around this. I ran into this when I tried to use the pkg-config command to build tkinter for PyPy.

mayeut commented 3 hours ago

These should be private to the cpython builds of manylinux2014. I'll check if/how I can remove all of this from /usr/local.

mattip commented 2 hours ago

Heh, don't hide it too much, I use it on PyPy :). FWIW, I fixed this by removing the missing stub static libs from the pkgconfig config file. Would you like a PR?

sed -i -e"s/ -ltclstub8.6//" /usr/local/lib/pkgconfig/tcl.pc
sed -i -e"s/ -ltkstub8.6//" /usr/local/lib/pkgconfig/tk.pc