pypa / pip

The Python package installer
https://pip.pypa.io/
MIT License
9.49k stars 3.01k forks source link

Add missing `pyproject_hooks` to DEBUNDLED preload list #12796

Closed mgorny closed 3 months ago

mgorny commented 3 months ago

Otherwise, tests fail to load:

ImportError while loading conftest '/tmp/portage/dev-python/pip-24.1-r1/work/pip-24.1/tests/conftest.py'.
tests/conftest.py:49: in <module>
    from pip._internal.utils.temp_dir import global_tempdir_manager
../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/temp_dir.py:20: in <module>
    from pip._internal.utils.misc import enum, rmtree
../pip-24.1-python3_13/install/usr/lib/python3.13/site-packages/pip/_internal/utils/misc.py:38: in <module>
    from pip._vendor.pyproject_hooks import BuildBackendHookCaller
E   ModuleNotFoundError: No module named 'pip._vendor.pyproject_hooks'
pradyunsg commented 3 months ago

https://pypi.org/project/pyproject-api/ is not the same as https://pypi.org/project/pyproject-hooks/ :)

mgorny commented 3 months ago

Ah, sorry, brainfart.

sbidoul commented 3 months ago

Thanks. Let's remove pep517 from that list at the same time.

mgorny commented 3 months ago

Thnaks. Let's remove pep517 from that list at the same time.

Added.

ichard26 commented 3 months ago

Ah, this still needs a NEWS entry. This can probably go under the vendor category.

mgorny commented 3 months ago

Ah, this still needs a NEWS entry. This can probably go under the vendor category.

Very well. I thought it's not worth including since FWIU this isn't really a "supported" territory but I'll add one.

ichard26 commented 3 months ago

My line of reasoning is that the vendor category is already obtuse to regular users, so it's likely primarily the downstream redistributors that read the vendor changelog entries. They may want to know about this change, hence my ask for an entry.

sbidoul commented 3 months ago

Pre-commit is complaining, though.

mgorny commented 3 months ago

That's what I get for merging suggestions :-). Lemme fix that quickly.

mgorny commented 3 months ago

Thanks!