search

pypa / pip

The Python package installer
https://pip.pypa.io/
MIT License
9.46k stars 3k forks source link

Bugfix release PRs do not trigger test suite on CI #12832

Closed pradyunsg closed 1 week ago

pradyunsg commented 2 months ago

Description

12831 did not run the test suite.

Expected behavior

The tests are run for a release PR, even if it is a bugfix release.

pip version

24.1.2

Python version

N/A

OS

N/A

How to Reproduce

File a bugfix PR, based on the procedure documented at https://pip.pypa.io/en/stable/development/release-process/#creating-a-bug-fix-release

Output

See PR linked above.

Code of Conduct

ichard26 commented 2 months ago

The problem is that bugfix release PRs do not result in a modification of any of the files that would trigger a test suite run. https://github.com/pypa/pip/blob/457ca6e17bf3e733e38e829c11d5680832cf6219/.github/workflows/ci.yml#L52-L57

For 24.1, the PR does bump the version number which was then detected by the determine-changes job.

For 24.1.2 (and 24.1.1), while the version number is bumped temporarily, it's reverted to the original version on main in the same PR, resulting in no net change in src/pip/_internal/__init__.py.

To work around this, perhaps it would be best to also trigger a test suite run when NEWS.rst is modified or when files are deleted from news/ (either of which typically only happens when cutting a new release).