search

pypa / pip

The Python package installer
https://pip.pypa.io/
MIT License
9.51k stars 3.02k forks source link

Start using .editorconfig for making lifes of users editors with its support a bit easier #7739

Closed KOLANICH closed 4 years ago

uranusjr commented 4 years ago

I am +1 to adding an .editorconfig since there’s no obvious downside. What goes in it would need more discussion.

pfmoore commented 4 years ago

I'm +0 as my editors (vim and VS Code) don't use that file, but if it helps others I don't really mind. But let's not turn it into a place for style battlegrounds :-)

KOLANICH commented 4 years ago

In fact there are plugins: https://github.com/editorconfig/editorconfig-vim https://github.com/editorconfig/editorconfig-vscode

pfmoore commented 4 years ago

Thank you! That's interesting to know, although I don't expect I'll use them as my personal config seems to match fine with what I need on the projects I work on. But it's good to know for future.

pradyunsg commented 4 years ago

Closing since we closed #7733.

@KOLANICH Please add "Related to #" to PRs, if you've filed an issue for them. It makes it easier for maintainers to manage the issue tracker. :)

chrahunt commented 4 years ago

Ah, thank you, I did not look in the commit message itself for an issue reference. I think my justification was pretty strong but if anyone thinks otherwise please say so!

Another note @KOLANICH, when mentioning issues it's usually a good idea NOT to mention them in the git commit title/description itself since that tends to spam the issue when rebasing/amending commits. Just the body of the PR message is OK.