Pipfile does not store "--no-binary"

jsaladich commented 1 year ago

Hi guys,

I found myself in the need of installing some modules with the argument --no-binary, when I realized about a potential issue / bug of pipenv

Issue description

When installing a Python module with argument --no-binary, pipenv does not retain this information in the Pipfile. Therefore, when running a pipenv install from this Pipfile, the module is not installed as desired.

Expected result

Pip requirements.txt file does take into account the --no-binary argument. e.g.

jupyterlab ==3.0.18
cartopy == 0.21.0 --no-binary :all:

Actual result

But in pipenv it does not. There is no traceability (nor for pipenv nor for the user) to know that module cartopy was installed with no binary

jupyterlab = "==3.0.18"
cartopy = "*"

Steps to replicate

The command used to install cartopy with --no-binary is: PIP_NO_BINARY=cartopy pipenv install cartopy

Pipenv version is: 2022.9.8

Thanks a lot for your time

jsaladich commented 1 year ago

@matteius has there been update on this topic? Thanks a lot!

matteius commented 1 year ago

Sorry @jsaladich -- I've been stretched for time so I haven't personally looked into it yet. I tagged it as an issue that anyone can take on knowing I won't be able to dig into it for a bit.

jsaladich commented 1 year ago

Thanks a lot for your prompt answer @matteius, let's hope somebody can find a fix on that issue. Best!

achilleasNP commented 1 year ago

@matteius I would like to take a stub on this. Could you please assign this to me.

jsaladich commented 1 year ago

Hi! Is there any update on that topic??

Thanks a lot and have a nice week!

matteius commented 1 year ago

@achilleasNP Just wondering if you ever got a chance to take a shot at this? I haven't really thought about it since you volunteered ...

pypa / pipenv