kalebmckale
commented
1 year ago Reviewing your description, I believe I know why it's failing. We (@matteius and myself) added a few additional features related to pip indexes, but you seemed to have found the one hole in the logic. Heh. Easy to fix though.
- If you add the
index-urlto yourpip.conffile, the logic that checks thepip.conffile will work properly. - If you separate the
--trusted-hostentries in yourextra-pip-args(at the command line, you have to specify only one hostname per--trusted-hostargument but you can repeat the argument, e.g.python -m pip install pypkg --trusted-host=pypi.org --trusted-host=pypi.python.orgthat will work also.
- If you specify the index inside the
requirements.txtfile, which would be unusual, but that would also work. - If you don't use a
requirements.txtfile and just install usingpipenv install pypkg, the install code will also do this correctly.
I plan to consolidate the trusted-host / verify_ssl logic into one source of truth and fix this hole in the logic in an upcoming version.
gdiepen
matteius
Allen-yan
delassio
dennisme
Issue description
I am behind a proxy and would like to use pipenv to build my docker images locally. Within my existing setup (using conda and pip) I have a build-argument in my Dockerfile indicating whether I want to disable the SSL certificate checking for conda and pip. This way, when building locally I choose to disable ssl verifications and while building on the CI/CD pipeline I don't provide this build-arg because the CI/CD workers have direct internet.
Using this approach, I can use the same Dockerfile both locally and on the CI/CD system by modifying just the build-arg and I don't have to try and conditionally include PEM certificate chains
I have tried things like:
--extra-pip-argslikepipenv -vvv install --extra-pip-args '--trusted-host "pypi.org files.pythonhosted.org pypi.python.org"' -r requirements.txtPIP_TRUSTED_HOSTenvironment variableI can't seem to be able to instruct pipenv to NOT check the certificates. From the documentation it is not clear how this should be possible
Expected result
I expect pipenv to be able to install packages without checking the SSL certificates if I instruct it to do so. I do know that this negates the purpose of SSL certificates, but this way I am able to not have to manually copy additional items (pem files) into my docker image during local builds
Actual result
Steps to replicate
I am running all the commands below in a clean ubuntu base image that has miniconda3 installed.
requirements.txt file
Pipfile
After running the command
pipenv -v install -r requirements.txt, automatically a Pipfile is generated with the following contents:Even after I change the verify_ssl in this file to false and run the pipenv install again (or pipenv lock), I still get the same CERTIFICATE_VERIFY_FAILED error.
Installing with pip itself works
When running the following command:
the package can be installed without a problem (i.e. no checking of the certificates).
pip config
$ pipenv --support
Pipenv version: `'2023.4.20'` Pipenv location: `'/opt/conda/lib/python3.10/site-packages/pipenv'` Python location: `'/opt/conda/bin/python'` OS Name: `'posix'` User pip version: `'23.1'` user Python installations found: - `3.10.8`: `/opt/conda/bin/python3` - `3.10.8`: `/opt/conda/bin/python` - `3.10.8`: `/opt/conda/bin/python3.1` PEP 508 Information: ``` {'implementation_name': 'cpython', 'implementation_version': '3.10.8', 'os_name': 'posix', 'platform_machine': 'x86_64', 'platform_python_implementation': 'CPython', 'platform_release': '4.19.128-microsoft-standard', 'platform_system': 'Linux', 'platform_version': '#1 SMP Tue Jun 23 12:58:10 UTC 2020', 'python_full_version': '3.10.8', 'python_version': '3.10', 'sys_platform': 'linux'} ``` System environment variables: - `CONDA_EXE` - `_CE_M` - `HOSTNAME` - `PWD` - `CONDA_PREFIX` - `HOME` - `LANG` - `LS_COLORS` - `CONDA_PROMPT_MODIFIER` - `https_proxy` - `TERM` - `_CE_CONDA` - `CONDA_SHLVL` - `SHLVL` - `HTTPS_PROXY` - `HTTP_PROXY` - `http_proxy` - `CONDA_PYTHON_EXE` - `CONDA_DEFAULT_ENV` - `LC_ALL` - `PATH` - `DEBIAN_FRONTEND` - `OLDPWD` - `_` - `PIP_DISABLE_PIP_VERSION_CHECK` - `PIP_PYTHON_PATH` - `PYTHONDONTWRITEBYTECODE` - `PYTHONFINDER_IGNORE_UNSUPPORTED` Pipenv–specific environment variables: Debug–specific environment variables: - `PATH`: `/opt/conda/bin:/opt/conda/condabin:/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin` - `LANG`: `C.UTF-8` - `PWD`: `/foo` --------------------------- Contents of `Pipfile` ('/foo/Pipfile'): ```toml [[source]] url = "https://pypi.org/simple" verify_ssl = false name = "pypi" [packages] six = "*" [dev-packages] [requires] python_version = "3.10" ```