pypa / pipenv

Python Development Workflow for Humans.
https://pipenv.pypa.io
MIT License
24.87k stars 1.87k forks source link

VCS install with --skip-lock fails with "empty revision" error #6189

Closed dennisvang closed 1 month ago

dennisvang commented 4 months ago

Issue description

Starting from a clean slate, with a dir containing only a single Pipfile with a single VCS dependency, running pipenv install --skip-lock fails with the error:

[pipenv.exceptions.InstallError]: ERROR: The URL 'git+https://github.com/myname/mypackage.git@#egg=mypackage' has an empty revision (after @) which is not supported. Include a revision after @ or remove @ from the URL. ERROR: Couldn't install package: {}

This happens even though a proper revision is specified, as in:

mypackage = {git = "https://github.com/myname/mypackage.git", ref = "v1.2.3"}

Moreover, the exact same Pipfile works without issue when doing a normal pipenv install, without --skip-lock.

Reproduced on Ubuntu 22.04.4 LTS and Amazon Linux 2023, running Python 3.11 with pipenv version 2024.0.1, both with editable = true and editable = false.

This is relevant for deployment to AWS Elastic Beanstalk, because that uses --skip-lock, as explained here, unless we provide a Pipfile.lock or a requirements.txt, which is not an option.

Expected result

I expected the specified version of the package to be installed without issue.

Actual result

command line output (using `editable=true`) ``` ~/Desktop/temp/pipfiletest $ pipenv install --skip-lock --verbose The flag --skip-lock has been reintroduced (but is not recommended). Without the lock resolver it is difficult to manage multiple package indexes, and hash checking is not provided. However it can help manage installs with current deficiencies in locking across platforms. Using python: None Path to python: None Creating a virtualenv for this project... Pipfile: /home/me/Desktop/temp/pipfiletest/Pipfile Using default python from /home/me/.pyenv/versions/3.11.6/bin/python3.11 (3.11.6) to create virtualenv... ⠙ Creating virtual environment...created virtual environment CPython3.11.6.final.0-64 in 98ms creator CPython3Posix(dest=/home/me/Desktop/temp/pipfiletest/.venv, clear=False, no_vcs_ignore=False, global=False) seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/me/.local/share/virtualenv) added seed packages: pip==24.1, setuptools==70.1.0, wheel==0.43.0 activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator ✔ Successfully created virtual environment! Virtualenv location: /home/me/Desktop/temp/pipfiletest/.venv Pipfile.lock not found, creating... Locking [packages] dependencies... Building requirements... Resolving dependencies... INFO:pipenv.patched.pip._internal.operations.prepare:Collecting requests@ git+https://github.com/psf/requests.git@v2.32.3 (from -r /tmp/pipenv-mxkx7csl-requirements/pipenv-sa1fms03-constraints.txt (line 2)) INFO:pipenv.patched.pip._internal.vcs.git:Cloning https://github.com/psf/requests.git (to revision v2.32.3) to /tmp/pip-temp-wco5fnm1/requests_bd858a3db95b46068091d420b431aa9a INFO:pip.subprocessor:Running command git clone --filter=blob:none --quiet https://github.com/psf/requests.git /tmp/pip-temp-wco5fnm1/requests_bd858a3db95b46068091d420b431aa9a INFO:pip.subprocessor:Running command git checkout -q 61e2240f283f15780ac2d0e2cfefb0fd6fdab627 INFO:pipenv.patched.pip._internal.vcs.git:Resolved https://github.com/psf/requests.git to commit 61e2240f283f15780ac2d0e2cfefb0fd6fdab627 INFO:pipenv.patched.pip._internal.cli.spinners:Installing build dependencies: started INFO:pipenv.patched.pip._internal.cli.spinners:Installing build dependencies: finished with status 'done' INFO:pipenv.patched.pip._internal.cli.spinners:Getting requirements to build wheel: started INFO:pipenv.patched.pip._internal.cli.spinners:Getting requirements to build wheel: finished with status 'done' INFO:pipenv.patched.pip._internal.cli.spinners:Preparing metadata (pyproject.toml): started INFO:pipenv.patched.pip._internal.cli.spinners:Preparing metadata (pyproject.toml): finished with status 'done' INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting() INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement( ExplicitRequirement(LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')), None) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(0) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement( SpecifierRequirement('charset-normalizer<4,>=2'), LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')) INFO:pipenv.patched.pip._internal.operations.prepare:Collecting charset-normalizer<4,>=2 (from requests@ git+https://github.com/psf/requests.git@v2.32.3->-r /tmp/pipenv-mxkx7csl-requirements/pipenv-sa1fms03-constraints.txt (line 2)) INFO:pipenv.patched.pip._internal.network.download:Using cached charset_normalizer-3.3.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (33 kB) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement( SpecifierRequirement('idna<4,>=2.5'), LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')) INFO:pipenv.patched.pip._internal.operations.prepare:Collecting idna<4,>=2.5 (from requests@ git+https://github.com/psf/requests.git@v2.32.3->-r /tmp/pipenv-mxkx7csl-requirements/pipenv-sa1fms03-constraints.txt (line 2)) INFO:pipenv.patched.pip._internal.network.download:Using cached idna-3.7-py3-none-any.whl.metadata (9.9 kB) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement( SpecifierRequirement('urllib3<3,>=1.21.1'), LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')) INFO:pipenv.patched.pip._internal.operations.prepare:Collecting urllib3<3,>=1.21.1 (from requests@ git+https://github.com/psf/requests.git@v2.32.3->-r /tmp/pipenv-mxkx7csl-requirements/pipenv-sa1fms03-constraints.txt (line 2)) INFO:pipenv.patched.pip._internal.network.download:Using cached urllib3-2.2.2-py3-none-any.whl.metadata (6.4 kB) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.adding_requirement( SpecifierRequirement('certifi>=2017.4.17'), LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')) INFO:pipenv.patched.pip._internal.operations.prepare:Collecting certifi>=2017.4.17 (from requests@ git+https://github.com/psf/requests.git@v2.32.3->-r /tmp/pipenv-mxkx7csl-requirements/pipenv-sa1fms03-constraints.txt (line 2)) INFO:pipenv.patched.pip._internal.network.download:Using cached certifi-2024.7.4-py3-none-any.whl.metadata (2.2 kB) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.pinning(LinkCandida te('git+https://github.com/psf/requests.git@v2.32.3')) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending_round(0, state) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(1) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.pinning(LinkCandida te('https://files.pythonhosted.org/packages/1c/d5/c84e1a17bf61d4df64ca866a1c9a913874b4e9bdc13 1ec689a0ad013fb36/certifi-2024.7.4-py3-none-any.whl (from https://pypi.org/simple/certifi/) (requires-python:>=3.6)')) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending_round(1, state) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(2) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.pinning(LinkCandida te('https://files.pythonhosted.org/packages/40/26/f35951c45070edc957ba40a5b1db3cf60a9dbb1b350 c2d5bef03e01e61de/charset_normalizer-3.3.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x8 6_64.whl (from https://pypi.org/simple/charset-normalizer/) (requires-python:>=3.7.0)')) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending_round(2, state) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(3) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.pinning(LinkCandida te('https://files.pythonhosted.org/packages/e5/3e/741d8c82801c347547f8a2a06aa57dbb1992be9e948 df2ea0eda2c8b79e8/idna-3.7-py3-none-any.whl (from https://pypi.org/simple/idna/) (requires-python:>=3.5)')) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending_round(3, state) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(4) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.pinning(LinkCandida te('https://files.pythonhosted.org/packages/ca/1c/89ffc63a9605b583d5df2be791a27bc1a42b7c32bab 68d3c8f2f73a98cd4/urllib3-2.2.2-py3-none-any.whl (from https://pypi.org/simple/urllib3/) (requires-python:>=3.8)')) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending_round(4, state) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.starting_round(5) INFO:pipenv.patched.pip._internal.resolution.resolvelib.reporter:Reporter.ending(State(mappin g=OrderedDict([('requests', LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')), ('certifi', LinkCandidate('https://files.pythonhosted.org/packages/1c/d5/c84e1a17bf61d4df64ca866a1c9a9138 74b4e9bdc131ec689a0ad013fb36/certifi-2024.7.4-py3-none-any.whl (from https://pypi.org/simple/certifi/) (requires-python:>=3.6)')), ('charset-normalizer', LinkCandidate('https://files.pythonhosted.org/packages/40/26/f35951c45070edc957ba40a5b1db3cf6 0a9dbb1b350c2d5bef03e01e61de/charset_normalizer-3.3.2-cp311-cp311-manylinux_2_17_x86_64.manyl inux2014_x86_64.whl (from https://pypi.org/simple/charset-normalizer/) (requires-python:>=3.7.0)')), ('idna', LinkCandidate('https://files.pythonhosted.org/packages/e5/3e/741d8c82801c347547f8a2a06aa57dbb 1992be9e948df2ea0eda2c8b79e8/idna-3.7-py3-none-any.whl (from https://pypi.org/simple/idna/) (requires-python:>=3.5)')), ('urllib3', LinkCandidate('https://files.pythonhosted.org/packages/ca/1c/89ffc63a9605b583d5df2be791a27bc1 a42b7c32bab68d3c8f2f73a98cd4/urllib3-2.2.2-py3-none-any.whl (from https://pypi.org/simple/urllib3/) (requires-python:>=3.8)'))]), criteria={'requests': Criterion((ExplicitRequirement(LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3 ')), via=None)), 'charset-normalizer': Criterion((SpecifierRequirement('charset-normalizer<4,>=2'), via=LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3'))), 'idna': Criterion((SpecifierRequirement('idna<4,>=2.5'), via=LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3'))), 'urllib3': Criterion((SpecifierRequirement('urllib3<3,>=1.21.1'), via=LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3'))), 'certifi': Criterion((SpecifierRequirement('certifi>=2017.4.17'), via=LinkCandidate('git+https://github.com/psf/requests.git@v2.32.3')))}, backtrack_causes=[])) INFO:pipenv.patched.pip._internal.network.download:Using cached certifi-2024.7.4-py3-none-any.whl (162 kB) INFO:pipenv.patched.pip._internal.network.download:Using cached charset_normalizer-3.3.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (140 kB) INFO:pipenv.patched.pip._internal.network.download:Using cached idna-3.7-py3-none-any.whl (66 kB) INFO:pipenv.patched.pip._internal.network.download:Using cached urllib3-2.2.2-py3-none-any.whl (121 kB) INFO:pipenv.patched.pip._internal.vcs.git:Cloning https://github.com/psf/requests.git (to revision v2.32.3) to /tmp/tmpe22p3gop INFO:pip.subprocessor:Running command git clone --filter=blob:none https://github.com/psf/requests.git /tmp/tmpe22p3gop INFO:pip.subprocessor:Cloning into '/tmp/tmpe22p3gop'... INFO:pip.subprocessor:Running command git checkout -q 61e2240f283f15780ac2d0e2cfefb0fd6fdab627 INFO:pipenv.patched.pip._internal.vcs.git:Resolved https://github.com/psf/requests.git to commit 61e2240f283f15780ac2d0e2cfefb0fd6fdab627 ⠼ Locking packages... ✔ Success! Warning: Error generating hash for requests. Locking [dev-packages] dependencies... Updated Pipfile.lock (157e8b246704e22e5cace5d55b8a257062903736fff6f8630b70cc1454d56bac)! To activate this project's virtualenv, run pipenv shell. Alternatively, run a command inside the virtualenv with pipenv run. To activate this project's virtualenv, run pipenv shell. Alternatively, run a command inside the virtualenv with pipenv run. Installing dependencies from Pipfile... Writing supplied requirement line to temporary file: '-e git+https://github.com/psf/requests.git@#egg=requests' Install Phase: Editable Requirements Preparing Installation of '-e git+https://github.com/psf/requests.git@#egg=requests' $ /home/me/Desktop/temp/pipfiletest/.venv/bin/python /home/me/.local/lib/python3.11/site-packages/pipenv/patched/pip/__pip-runner__.py install -i https://pypi.org/simple --no-input --upgrade -r /tmp/pipenv-145hnd_9-requirements/pipenv-5csjrudk-reqs.txt Using source directory: '/home/me/Desktop/temp/pipfiletest/.venv/src' Obtaining requests from git+https://github.com/psf/requests.git@#egg=requests (from -r /tmp/pipenv-145hnd_9-requirements/pipenv-5csjrudk-reqs.txt (line 1)) ERROR: The URL 'git+https://github.com/psf/requests.git@#egg=requests' has an empty revision (after @) which is not supported. Include a revision after @ or remove @ from the URL. [pipenv.exceptions.InstallError]: ERROR: The URL 'git+https://github.com/psf/requests.git@#egg=requests' has an empty revision (after @) which is not supported. Include a revision after @ or remove @ from the URL. ERROR: Couldn't install package: {} Package installation failed... ```

Steps to replicate

  1. Create an empty dir, add the following Pipfile:

    [[source]]
    name = "pypi"
    url = "https://pypi.org/simple"
    verify_ssl = true
    
    [packages]
    requests = {git = "https://github.com/psf/requests.git", ref = "v2.32.3"}

    The requests package is just a random example. The same issue arises with other packages.

  2. Run pipenv install --skip-lock


$ pipenv --support Pipenv version: `'2024.0.1'` Pipenv location: `'/home/me/.local/lib/python3.11/site-packages/pipenv'` Python location: `'/home/me/.pyenv/versions/3.11.6/bin/python3.11'` OS Name: `'posix'` User pip version: `'24.0'` user Python installations found: PEP 508 Information: ``` {'implementation_name': 'cpython', 'implementation_version': '3.11.6', 'os_name': 'posix', 'platform_machine': 'x86_64', 'platform_python_implementation': 'CPython', 'platform_release': '6.5.0-41-generic', 'platform_system': 'Linux', 'platform_version': '#41~22.04.2-Ubuntu SMP PREEMPT_DYNAMIC Mon Jun 3 ' '11:32:55 UTC 2', 'python_full_version': '3.11.6', 'python_version': '3.11', 'sys_platform': 'linux'} ``` System environment variables: - `SHELL` - `SESSION_MANAGER` - `QT_ACCESSIBILITY` - `PIPENV_VENV_IN_PROJECT` - `COLORTERM` - `PYENV_SHELL` - `XDG_CONFIG_DIRS` - `SSH_AGENT_LAUNCHER` - `XDG_MENU_PREFIX` - `GNOME_DESKTOP_SESSION_ID` - `LANGUAGE` - `LC_ADDRESS` - `GNOME_SHELL_SESSION_MODE` - `LC_NAME` - `SSH_AUTH_SOCK` - `GIT_PS1_SHOWDIRTYSTATE` - `XMODIFIERS` - `DESKTOP_SESSION` - `LC_MONETARY` - `GTK_MODULES` - `PWD` - `LOGNAME` - `XDG_SESSION_DESKTOP` - `XDG_SESSION_TYPE` - `SYSTEMD_EXEC_PID` - `XAUTHORITY` - `HOME` - `USERNAME` - `IM_CONFIG_PHASE` - `LC_PAPER` - `LANG` - `LS_COLORS` - `XDG_CURRENT_DESKTOP` - `VTE_VERSION` - `WAYLAND_DISPLAY` - `GNOME_TERMINAL_SCREEN` - `GNOME_SETUP_DISPLAY` - `LESSCLOSE` - `XDG_SESSION_CLASS` - `TERM` - `LC_IDENTIFICATION` - `LESSOPEN` - `USER` - `GNOME_TERMINAL_SERVICE` - `DISPLAY` - `SHLVL` - `LC_TELEPHONE` - `QT_IM_MODULE` - `LC_MEASUREMENT` - `PAPERSIZE` - `XDG_RUNTIME_DIR` - `PYENV_ROOT` - `LC_TIME` - `XDG_DATA_DIRS` - `PATH` - `GDMSESSION` - `DBUS_SESSION_BUS_ADDRESS` - `LC_NUMERIC` - `OLDPWD` - `_` - `PIP_DISABLE_PIP_VERSION_CHECK` - `PYTHONDONTWRITEBYTECODE` - `PYTHONFINDER_IGNORE_UNSUPPORTED` Pipenv–specific environment variables: - `PIPENV_VENV_IN_PROJECT`: `1` Debug–specific environment variables: - `PATH`: `/home/me/.pyenv/versions/3.9.18/bin:/home/me/.pyenv/versions/3.8.18/bin:/home/me/.pyenv/versions/3.11.6/bin:/home/me/.pyenv/versions/3.8.13/bin:/home/me/.pyenv/shims:/home/me/.npm-global/bin:/home/me/.local/bin:/home/me/.pyenv/bin:/home/me/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin` - `SHELL`: `/bin/bash` - `LANG`: `en_CA.UTF-8` - `PWD`: `/home/me/Desktop/temp/pipfiletest` --------------------------- Contents of `Pipfile` ('/home/me/Desktop/temp/pipfiletest/Pipfile'): ```toml [[source]] name = "pypi" url = "https://pypi.org/simple" verify_ssl = true [packages] requests = {git = "https://github.com/psf/requests.git", ref = "v2.32.3", editable = true} ``` Contents of `Pipfile.lock` ('/home/me/Desktop/temp/pipfiletest/Pipfile.lock'): ```json { "_meta": { "hash": { "sha256": "157e8b246704e22e5cace5d55b8a257062903736fff6f8630b70cc1454d56bac" }, "pipfile-spec": 6, "requires": {}, "sources": [ { "name": "pypi", "url": "https://pypi.org/simple", "verify_ssl": true } ] }, "default": { "certifi": { "hashes": [ "sha256:5a1e7645bc0ec61a09e26c36f6106dd4cf40c6db3a1fb6352b0244e7fb057c7b", "sha256:c198e21b1289c2ab85ee4e67bb4b4ef3ead0892059901a8d5b622f24a1101e90" ], "markers": "python_version >= '3.6'", "version": "==2024.7.4" }, "charset-normalizer": { "hashes": [ "sha256:06435b539f889b1f6f4ac1758871aae42dc3a8c0e24ac9e60c2384973ad73027", "sha256:06a81e93cd441c56a9b65d8e1d043daeb97a3d0856d177d5c90ba85acb3db087", "sha256:0a55554a2fa0d408816b3b5cedf0045f4b8e1a6065aec45849de2d6f3f8e9786", "sha256:0b2b64d2bb6d3fb9112bafa732def486049e63de9618b5843bcdd081d8144cd8", "sha256:10955842570876604d404661fbccbc9c7e684caf432c09c715ec38fbae45ae09", "sha256:122c7fa62b130ed55f8f285bfd56d5f4b4a5b503609d181f9ad85e55c89f4185", "sha256:1ceae2f17a9c33cb48e3263960dc5fc8005351ee19db217e9b1bb15d28c02574", "sha256:1d3193f4a680c64b4b6a9115943538edb896edc190f0b222e73761716519268e", "sha256:1f79682fbe303db92bc2b1136016a38a42e835d932bab5b3b1bfcfbf0640e519", "sha256:2127566c664442652f024c837091890cb1942c30937add288223dc895793f898", "sha256:22afcb9f253dac0696b5a4be4a1c0f8762f8239e21b99680099abd9b2b1b2269", "sha256:25baf083bf6f6b341f4121c2f3c548875ee6f5339300e08be3f2b2ba1721cdd3", "sha256:2e81c7b9c8979ce92ed306c249d46894776a909505d8f5a4ba55b14206e3222f", "sha256:3287761bc4ee9e33561a7e058c72ac0938c4f57fe49a09eae428fd88aafe7bb6", "sha256:34d1c8da1e78d2e001f363791c98a272bb734000fcef47a491c1e3b0505657a8", "sha256:37e55c8e51c236f95b033f6fb391d7d7970ba5fe7ff453dad675e88cf303377a", "sha256:3d47fa203a7bd9c5b6cee4736ee84ca03b8ef23193c0d1ca99b5089f72645c73", "sha256:3e4d1f6587322d2788836a99c69062fbb091331ec940e02d12d179c1d53e25fc", "sha256:42cb296636fcc8b0644486d15c12376cb9fa75443e00fb25de0b8602e64c1714", "sha256:45485e01ff4d3630ec0d9617310448a8702f70e9c01906b0d0118bdf9d124cf2", "sha256:4a78b2b446bd7c934f5dcedc588903fb2f5eec172f3d29e52a9096a43722adfc", "sha256:4ab2fe47fae9e0f9dee8c04187ce5d09f48eabe611be8259444906793ab7cbce", "sha256:4d0d1650369165a14e14e1e47b372cfcb31d6ab44e6e33cb2d4e57265290044d", "sha256:549a3a73da901d5bc3ce8d24e0600d1fa85524c10287f6004fbab87672bf3e1e", "sha256:55086ee1064215781fff39a1af09518bc9255b50d6333f2e4c74ca09fac6a8f6", "sha256:572c3763a264ba47b3cf708a44ce965d98555f618ca42c926a9c1616d8f34269", "sha256:573f6eac48f4769d667c4442081b1794f52919e7edada77495aaed9236d13a96", "sha256:5b4c145409bef602a690e7cfad0a15a55c13320ff7a3ad7ca59c13bb8ba4d45d", "sha256:6463effa3186ea09411d50efc7d85360b38d5f09b870c48e4600f63af490e56a", "sha256:65f6f63034100ead094b8744b3b97965785388f308a64cf8d7c34f2f2e5be0c4", "sha256:663946639d296df6a2bb2aa51b60a2454ca1cb29835324c640dafb5ff2131a77", "sha256:6897af51655e3691ff853668779c7bad41579facacf5fd7253b0133308cf000d", "sha256:68d1f8a9e9e37c1223b656399be5d6b448dea850bed7d0f87a8311f1ff3dabb0", "sha256:6ac7ffc7ad6d040517be39eb591cac5ff87416c2537df6ba3cba3bae290c0fed", "sha256:6b3251890fff30ee142c44144871185dbe13b11bab478a88887a639655be1068", "sha256:6c4caeef8fa63d06bd437cd4bdcf3ffefe6738fb1b25951440d80dc7df8c03ac", "sha256:6ef1d82a3af9d3eecdba2321dc1b3c238245d890843e040e41e470ffa64c3e25", "sha256:753f10e867343b4511128c6ed8c82f7bec3bd026875576dfd88483c5c73b2fd8", "sha256:7cd13a2e3ddeed6913a65e66e94b51d80a041145a026c27e6bb76c31a853c6ab", "sha256:7ed9e526742851e8d5cc9e6cf41427dfc6068d4f5a3bb03659444b4cabf6bc26", "sha256:7f04c839ed0b6b98b1a7501a002144b76c18fb1c1850c8b98d458ac269e26ed2", "sha256:802fe99cca7457642125a8a88a084cef28ff0cf9407060f7b93dca5aa25480db", "sha256:80402cd6ee291dcb72644d6eac93785fe2c8b9cb30893c1af5b8fdd753b9d40f", "sha256:8465322196c8b4d7ab6d1e049e4c5cb460d0394da4a27d23cc242fbf0034b6b5", "sha256:86216b5cee4b06df986d214f664305142d9c76df9b6512be2738aa72a2048f99", "sha256:87d1351268731db79e0f8e745d92493ee2841c974128ef629dc518b937d9194c", "sha256:8bdb58ff7ba23002a4c5808d608e4e6c687175724f54a5dade5fa8c67b604e4d", "sha256:8c622a5fe39a48f78944a87d4fb8a53ee07344641b0562c540d840748571b811", "sha256:8d756e44e94489e49571086ef83b2bb8ce311e730092d2c34ca8f7d925cb20aa", "sha256:8f4a014bc36d3c57402e2977dada34f9c12300af536839dc38c0beab8878f38a", "sha256:9063e24fdb1e498ab71cb7419e24622516c4a04476b17a2dab57e8baa30d6e03", "sha256:90d558489962fd4918143277a773316e56c72da56ec7aa3dc3dbbe20fdfed15b", "sha256:923c0c831b7cfcb071580d3f46c4baf50f174be571576556269530f4bbd79d04", "sha256:95f2a5796329323b8f0512e09dbb7a1860c46a39da62ecb2324f116fa8fdc85c", "sha256:96b02a3dc4381e5494fad39be677abcb5e6634bf7b4fa83a6dd3112607547001", "sha256:9f96df6923e21816da7e0ad3fd47dd8f94b2a5ce594e00677c0013018b813458", "sha256:a10af20b82360ab00827f916a6058451b723b4e65030c5a18577c8b2de5b3389", "sha256:a50aebfa173e157099939b17f18600f72f84eed3049e743b68ad15bd69b6bf99", "sha256:a981a536974bbc7a512cf44ed14938cf01030a99e9b3a06dd59578882f06f985", "sha256:a9a8e9031d613fd2009c182b69c7b2c1ef8239a0efb1df3f7c8da66d5dd3d537", "sha256:ae5f4161f18c61806f411a13b0310bea87f987c7d2ecdbdaad0e94eb2e404238", "sha256:aed38f6e4fb3f5d6bf81bfa990a07806be9d83cf7bacef998ab1a9bd660a581f", "sha256:b01b88d45a6fcb69667cd6d2f7a9aeb4bf53760d7fc536bf679ec94fe9f3ff3d", "sha256:b261ccdec7821281dade748d088bb6e9b69e6d15b30652b74cbbac25e280b796", "sha256:b2b0a0c0517616b6869869f8c581d4eb2dd83a4d79e0ebcb7d373ef9956aeb0a", "sha256:b4a23f61ce87adf89be746c8a8974fe1c823c891d8f86eb218bb957c924bb143", "sha256:bd8f7df7d12c2db9fab40bdd87a7c09b1530128315d047a086fa3ae3435cb3a8", "sha256:beb58fe5cdb101e3a055192ac291b7a21e3b7ef4f67fa1d74e331a7f2124341c", "sha256:c002b4ffc0be611f0d9da932eb0f704fe2602a9a949d1f738e4c34c75b0863d5", "sha256:c083af607d2515612056a31f0a8d9e0fcb5876b7bfc0abad3ecd275bc4ebc2d5", "sha256:c180f51afb394e165eafe4ac2936a14bee3eb10debc9d9e4db8958fe36afe711", "sha256:c235ebd9baae02f1b77bcea61bce332cb4331dc3617d254df3323aa01ab47bd4", "sha256:cd70574b12bb8a4d2aaa0094515df2463cb429d8536cfb6c7ce983246983e5a6", "sha256:d0eccceffcb53201b5bfebb52600a5fb483a20b61da9dbc885f8b103cbe7598c", "sha256:d965bba47ddeec8cd560687584e88cf699fd28f192ceb452d1d7ee807c5597b7", "sha256:db364eca23f876da6f9e16c9da0df51aa4f104a972735574842618b8c6d999d4", "sha256:ddbb2551d7e0102e7252db79ba445cdab71b26640817ab1e3e3648dad515003b", "sha256:deb6be0ac38ece9ba87dea880e438f25ca3eddfac8b002a2ec3d9183a454e8ae", "sha256:e06ed3eb3218bc64786f7db41917d4e686cc4856944f53d5bdf83a6884432e12", "sha256:e27ad930a842b4c5eb8ac0016b0a54f5aebbe679340c26101df33424142c143c", "sha256:e537484df0d8f426ce2afb2d0f8e1c3d0b114b83f8850e5f2fbea0e797bd82ae", "sha256:eb00ed941194665c332bf8e078baf037d6c35d7c4f3102ea2d4f16ca94a26dc8", "sha256:eb6904c354526e758fda7167b33005998fb68c46fbc10e013ca97f21ca5c8887", "sha256:eb8821e09e916165e160797a6c17edda0679379a4be5c716c260e836e122f54b", "sha256:efcb3f6676480691518c177e3b465bcddf57cea040302f9f4e6e191af91174d4", "sha256:f27273b60488abe721a075bcca6d7f3964f9f6f067c8c4c605743023d7d3944f", "sha256:f30c3cb33b24454a82faecaf01b19c18562b1e89558fb6c56de4d9118a032fd5", "sha256:fb69256e180cb6c8a894fee62b3afebae785babc1ee98b81cdf68bbca1987f33", "sha256:fd1abc0d89e30cc4e02e4064dc67fcc51bd941eb395c502aac3ec19fab46b519", "sha256:ff8fa367d09b717b2a17a052544193ad76cd49979c805768879cb63d9ca50561" ], "markers": "python_full_version >= '3.7.0'", "version": "==3.3.2" }, "idna": { "hashes": [ "sha256:028ff3aadf0609c1fd278d8ea3089299412a7a8b9bd005dd08b9f8285bcb5cfc", "sha256:82fee1fc78add43492d3a1898bfa6d8a904cc97d8427f683ed8e798d07761aa0" ], "markers": "python_version >= '3.5'", "version": "==3.7" }, "requests": { "editable": true, "git": "https://github.com/psf/requests.git", "markers": "python_version >= '3.8'", "ref": "0e322af87745eff34caffe4df68456ebc20d9068" }, "urllib3": { "hashes": [ "sha256:a448b2f64d686155468037e1ace9f2d2199776e17f0a46610480d311f73e3472", "sha256:dd505485549a7a552833da5e6063639d0d177c04f23bc3864e41e5dc5f612168" ], "markers": "python_version >= '3.8'", "version": "==2.2.2" } }, "develop": {} } ```
matteius commented 2 months ago

@dennisvang I have the fix out for PR now and am confident in that change -- it will no longer run a lock cycle during --skip-lock and handles your example well.

dennisvang commented 2 months ago

@matteius Thanks for fixing this! Looks good to me.