search

pypa / pipfile

Other
3.24k stars 145 forks source link

refactor Pipfile.find #83

Closed ofek closed 7 years ago

ofek commented 7 years ago

@kennethreitz Ready for review :)

kennethreitz commented 7 years ago

this looks great! would like to test it manually first.

kennethreitz commented 7 years ago

but i'll trust that it works :)

kennethreitz commented 7 years ago

this actually breaks pipenv functionality

ofek commented 7 years ago

What did it break?

ofek commented 7 years ago

Ah sorry, the os.walk topdown=False docs are very misleading. Yes please revert :/

kennethreitz commented 7 years ago

No worries :)

edbennett commented 5 years ago

This doesn't seem to have been reverted? (I was just looking through the old version of the code installed on my machine, also thought it would benefit from refactoring, so came to look at the current version of the code and found it broken...)