pypa / pipfile

Other
3.24k stars 145 forks source link

editable line to use egg packagage #93

Closed gsemet closed 6 years ago

gsemet commented 6 years ago

Hello.

I would like to propose the following amendement for the equivalent of pip install -e .

Instead of:

"e1839a8" = {path = ".", editable = true}

I would like to have:

"mypackage" = {path = ".", editable = true}

This would allow to get directly the name of the egg I am working on only by reading the Pipfile

gsemet commented 6 years ago

not relevant, pip does not support egg name when installing from local path

davilima6 commented 6 years ago

What's the reason for this fixed hash e1839a8? I see it comes from Pipenv but it doesn't seem to vary across projects (it's even in README).

It'd be more logical/readable to use the name argument provided to setuptools.setup() in setup.py, what do you think?

kennethreitz commented 6 years ago

it's a sha256 of '.'. pull requests accepted!

kennethreitz commented 6 years ago

you can change it to whatever you like. it's just a placeholder

jacebrowning commented 6 years ago

I have found that if I run python setup.py develop first, I am able to use the actual package name in the Pipfile.

It would be nice if the presence of path = "." invoked setup.py automatically.