1.6.0: fix release tag creation

pypa / pipx

Install and Run Python Applications in Isolated Environments

https://pipx.pypa.io

MIT License

10.23k stars 411 forks source link

Closed huxuan closed 4 months ago

huxuan commented 4 months ago

[ ] I have added a news fragment under changelog.d/ (if the patch affects the end users)

Fix release tag creation, the mathieudutour/github-tag-action will create v1.6.0 rather than 1.6.0 which causes the broken of release workflow

Tested by running

# command(s) to exercise these changes

chrysle commented 4 months ago

@dukecat0 The version was missing from the PR title...

dukecat0 commented 4 months ago

Thanks for the heads up 😅

dukecat0 commented 4 months ago

Maybe we need to add workflow_dispatch: to trigger the deployment manually?

chrysle commented 4 months ago

Sounds good, it's getting quite annoying now.

chrysle commented 4 months ago

Can't delete the wrong tags created, by the way.

dukecat0 commented 4 months ago

I just opened #1436 for this.

dukecat0 commented 4 months ago

Can't delete the wrong tags created, by the way.

I just deleted those two wrong tags with CLI.