search

pypa / pipx

Install and Run Python Applications in Isolated Environments
https://pipx.pypa.io
MIT License
9.51k stars 396 forks source link

Add quotes to title and fix tag name in release action #1437

Closed dukecat0 closed 1 month ago

chrysle commented 1 month ago

Whee, it worked! Except for the zipapp, which we'll need to upload manually. Done. It's because the output comes now from the create-tag job (another oversight of mine). Could you amend that?

dukecat0 commented 1 month ago

Could you amend that?

Fixed!

chrysle commented 1 month ago

Thanks! Don't we also need to specify the new dependency in the needs field?

dukecat0 commented 1 month ago

Looks like everthing should work now.

dukecat0 commented 1 month ago

Btw, I removed pipx.pyz from release since it doesn't provide the correct version when running pipx --version.

chrysle commented 1 month ago

Btw, I removed pipx.pyz from release since it doesn't provide the correct version when running pipx --version.

Ah, right. Uploaded a correctly generated one. I think we need to copy over the job to generate the zipapp then.

dukecat0 commented 1 month ago

Or maybe we can generate it by re-running failed jobs:

image
chrysle commented 1 month ago

For this time, it's done anyway. For the future, it should be necessary to generate the zipapp directly before uploading to the release – as you pointed out, retrieving it from the preceding tests run results in incorrect version information. Can that be done in this PR?

dukecat0 commented 1 month ago

generate the zipapp directly before uploading to the release

Done in the latest commit.