search

pypa / readme_renderer

Safely render long_description/README files in Warehouse
Apache License 2.0
158 stars 89 forks source link

Factor out python-future #134

Closed asottile closed 6 years ago

asottile commented 6 years ago

Resolves #128

asottile commented 6 years ago

a note here: the tests are very good in making sure that html_escape is working properly, my original attempt was just using cgi.escape but I noticed that doesn't cover escaping single quotes

theacodes commented 6 years ago

Thank you!

asottile commented 6 years ago

and thank you! :tada:

ssbarnea commented 6 years ago

@asottile Can you please make a new relase on pypi? The unlisted html dependency broke few openstack projects and it would be easier if we don't have to merge a workaround.

asottile commented 6 years ago

@ssbarnea heh, yet another project I don't have merge/push access too -- I'm curious though, what broke from the openstack side? (do you have a stacktrace?)

di commented 6 years ago

@ssbarnea Could you open a new issue? The html module is in the standard library but it looks like it (or possibly just the escape function) was added in 3.2, so the version_info check here might be wrong.

asottile commented 6 years ago

I would hope nobody is using 3.1 / 3.0 in 2018 😆