No need to warn about markdown if it's never used, for #142

pypa / readme_renderer

Safely render long_description/README files in Warehouse

Apache License 2.0

157 stars 88 forks source link

No need to warn about markdown if it's never used, for #142 #143

Closed nedbat closed 5 years ago

nedbat commented 5 years ago

Turns out it was super simple.

di commented 5 years ago

Thanks! But this is not necessary. Your issue has been fixed in pypa/twine#421 but hasn't been released yet.

Julian commented 5 years ago

If it matters, I think I agree with @nedbat that even though it's fixed downstream seems unnecessary to warn twice here even if it's fixed downstream too.

nedbat commented 5 years ago

I guess in some way it isn't necessary, but only because you know how this file is used in twine. Looked at in isolation, the file still has an annoying behavior: it has the exact same warning twice: once on import, and then again if the renderer is called. That seems unnecessary.

nedbat commented 5 years ago

Sounds like you don't want this?