search

pypa / readme_renderer

Safely render long_description/README files in Warehouse
Apache License 2.0
158 stars 88 forks source link

Fix regression for image height/width #164

Closed di closed 4 years ago

di commented 4 years ago

This fixes a regression introduced in #113 where height/width attributes were removed from images defined in reStructuredText.

More discussion here: https://github.com/pypa/readme_renderer/pull/113#discussion_r206366539

matthewfeickert commented 4 years ago

Thanks for making this fix PR so quickly, @di. This is really great to see. :)

For the uninitiated like myself who don't know much about how Warehouse works, this will go into Warehouse with release 26.0, correct? Looking at the release history for readme_renderer would this maybe be later in 2020?

di commented 4 years ago

Nope, right now: https://pypi.org/project/readme-renderer/26.0/

matthewfeickert commented 4 years ago

That's fantastic! :D Thank you so much!

di commented 4 years ago

Once the dependency gets pulled into warehouse & merged, old descriptions should get eventually re-rendered, so you shouldn't have to make a new release to see the update (although new releases will definitely get it right away).