search

pypa / readme_renderer

Safely render long_description/README files in Warehouse
Apache License 2.0
158 stars 89 forks source link

test: update html attribute order #235

Closed miketheman closed 2 years ago

miketheman commented 2 years ago

With bleach 5.0.0, attribute order has changed to be preserved from the origin, rather than alphabetized for consistency.

These tests failed due to the output change.

Closes: #234

Signed-off-by: Mike Fiedler miketheman@gmail.com

miketheman commented 2 years ago

Well, this is now fun. 😁 Since bleach 5.x dropped support for Python 3.6, the older 4.x version is installed, and fails the tests.

Question: When do we feel comfortable dropping support for Python 3.6 testing (or even listed in the classifiers)?

di commented 2 years ago

Question: When do we feel comfortable dropping support for Python 3.6 testing (or even listed in the classifiers)?

I'm fine with dropping support now, Python 3.6 is EOL.

di commented 2 years ago

@miketheman Would you mind dropping support in a separate PR?

miketheman commented 2 years ago

@miketheman Would you mind dropping support in a separate PR?

No problem, will move that commit (and a couple others) to a different PR, and get that done before this one.

miketheman commented 2 years ago

@di our powers combined, I think we did it!

di commented 2 years ago

Thank you @miketheman! One last thing, would you like to create a PR to bump for release?

miketheman commented 2 years ago

Sure thing - coming right up!