Simplify FileList._safe_path for PathLike support

pypa / setuptools

Official project repository for the Setuptools build system

https://pypi.org/project/setuptools/

MIT License

2.35k stars 1.15k forks source link

Simplify FileList._safe_path for PathLike support #4251

Open jaraco opened 3 months ago

jaraco commented 3 months ago

In FileList.append
Refactor _safe_path into three functions. Remove support for bytes. Allow for path to be PathLike.

Summary of changes

Supports pypa/distutils#237.

Pull Request Checklist

[x] Changes have tests
[x] News fragment added in newsfragments/. (See [documentation][PR docs] for details)

[PR docs]: https://setuptools.pypa.io/en/latest/development/developer-guide.html#making-a-pull-request

jaraco commented 3 weeks ago

I wonder if anyone is still dependent on the support for bytes decoding. I guess we should either retain compatibility or declare the change as backward-incompatible. I'll do the latter; we can back out the change (restore support for bytes) if it turns out to cause any trouble.