search

pypa / setuptools

Official project repository for the Setuptools build system
https://pypi.org/project/setuptools/
MIT License
2.53k stars 1.19k forks source link

fix ldcxxshared contains ccache #4749

Closed trim21 closed 1 week ago

trim21 commented 1 week ago

Summary of changes

LDCXXSHARED will be "ccache /usr/bin/c++ -shared" if it's compiled with ccache, and it will fail linker

I'm not sure how to test this...

Closes https://github.com/pypa/setuptools/issues/4748

Pull Request Checklist

[PR docs]: https://setuptools.pypa.io/en/latest/development/developer-guide.html#making-a-pull-request

abravalheri commented 1 week ago

Hi @trim21, thank you very much for investigating this.

Could you please provide the feedback and PR directly to the https://github.com/pypa/distutils repository please?

The setuptools/_distutils folder is not directly modified in the pypa/setuptools repository, instead we periodically merge from pypa/distutils (this practice is documented in https://setuptools.pypa.io/en/latest/development/developer-guide.html#code-conventions-and-other-practices).

trim21 commented 1 week ago

Oh, sorry. I find this file by debugger, didn't notice the file path

abravalheri commented 1 week ago

That is not a problem at all, just some internal organisation. Thank you very much for working on this.

trim21 commented 1 week ago

https://github.com/pypa/distutils/pull/313