Remove `strip_trailing_zero` arg from `canonicalize_version` call

pypa / setuptools

Official project repository for the Setuptools build system

https://pypi.org/project/setuptools/

MIT License

2.54k stars 1.19k forks source link

Remove `strip_trailing_zero` arg from `canonicalize_version` call #4752

Closed clayote closed 1 week ago

clayote commented 1 week ago

…_core_metadata._distribution_fullname

A comment above suggests that the get_fullname function really isn't needed, but it got called in a project I was building anyway. This fixes it.

Summary of changes

Closes

Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in newsfragments/. (See [documentation][PR docs] for details)

[PR docs]: https://setuptools.pypa.io/en/latest/development/developer-guide.html#making-a-pull-request

abravalheri commented 1 week ago

Hi @clayote, thank you very much for the contribution, but I am afraid this fix is not strictly correct. Setuptools do need the strip_trailing_zero.

I suggest installing the latest version of packaging in your environment and see if this helps with your problem. Alternatively you can consider using setuptools[core] instead.

abravalheri commented 1 week ago

Please see the discussion in https://github.com/pypa/setuptools/issues/4483.