pypa / setuptools

Official project repository for the Setuptools build system
https://pypi.org/project/setuptools/
MIT License
2.53k stars 1.19k forks source link

Empty tuple instead of None for PlatformInfo version properties fallthrough #4754

Closed Avasam closed 2 days ago

Avasam commented 3 days ago

Summary of changes

Changed the WindowsSdkVersion, FrameworkVersion32 and FrameworkVersion64 properties of setuptools.msvc.PlatformInfo to return an empty tuple instead of None as a fallthrough case.

This also better matches the existing documentation which does not mention returning None.

In setuptools these are always used directly in iterations without ever checking for None or truthyness.

Fixes for https://github.com/pypa/setuptools/pull/4744

Pull Request Checklist

[PR docs]: https://setuptools.pypa.io/en/latest/development/developer-guide.html#making-a-pull-request

abravalheri commented 2 days ago

Thank you