search

pypa / setuptools_scm

the blessed package to manage your versions by scm tags
https://setuptools-scm.readthedocs.io/en/latest/
MIT License
833 stars 210 forks source link

Different hash (length) in generated name #1052

Open senysenyseny16 opened 1 week ago

senysenyseny16 commented 1 week ago

Wheels are built in the same environment, periodically some of the wheels have a different hash, differing in length by one digit.

package_name-3.7.2.dev52+g84cda2814-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
package_name-3.7.2.dev52+g84cda281-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
package_name-3.7.2.dev52+g84cda281-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
g84cda281   [3.9, 3.10]
g84cda2814  [3.8]

version: latest

RonnyPfannschmidt commented 1 week ago

What git versions are the different builders using

It may be necessary to as always use the long describe

senysenyseny16 commented 1 week ago

All three wheels are built in the same image with the same version of Git:

❯ docker run -it --rm quay.io/pypa/manylinux2014_x86_64
[root@b9d0ea36c864 /]# git --version
git version 2.45.2

From build to build, the incorrect names change for different versions of Python.

RonnyPfannschmidt commented 1 week ago

Thanks for the details, it seems like we hit a non-deterministic case in git and need to ensure a consistent minimum length