pypa / trove-classifiers

Canonical source for classifiers on PyPI.
https://pypi.org/p/trove-classifiers/
Apache License 2.0
134 stars 95 forks source link

Added PySimpleGUI versions 4 and 5 as a Framework #157

Closed PySimpleGUI closed 10 months ago

PySimpleGUI commented 10 months ago

Request to add a new Trove classifier.

The name of the classifier(s) you would like to add:

Why do you want to add this classifier?

PySimpleGUI, the popular GUI framework for Python, is about to ship a major upgrade. PySimpleGUI 5 features significant enhancements, including new features, new tools, and new support plans. PyPi users will find value in being able to distinguish between the various versions, and the best mechanism is to add distinctive classifiers.

PySimpleGUI commented 10 months ago

Am I missing some required information?

Lemme see if this is a secret phrase as it worked for the last approved pull request.

@di are you available to merge this easy one?

[ EDIT ] In case it doesn't come through... this was meant as humor 😉 I know people are busy.

di commented 10 months ago

Please see the linting failures.

PySimpleGUI commented 10 months ago

DOH! Sorry about the botched sort.

Thank you very much @di!

image

I think I fixed it correctly.

PySimpleGUI commented 10 months ago

Oops....

image

I'll keep trying!

PySimpleGUI commented 10 months ago

image

Awesome!

Thank you so much Dustin for the help!

PySimpleGUI commented 9 months ago

When do these changes show up on the PyPI site / become usable by packages being uploaded?

miketheman commented 9 months ago

When do these changes show up on the PyPI site / become usable by packages being uploaded?

Now that they have been merged and a release containing the changes has been published, it takes a day or two for Dependabot to suggest the change to warehouse, and then it might take a few days for us to merge it in.

However I believe these have been merged already - as part of https://github.com/pypi/warehouse/pull/14914

di commented 9 months ago

When the dependency gets update on PyPI, which has happened: https://github.com/pypi/warehouse/blob/d74fff4e3d89b136fec5e17c180620c9cfcef0f3/requirements/main.txt#L1628-L1631

However looks like we had a deployment failure: https://github.com/pypi/warehouse/actions/runs/6867233971/attempts/1

di commented 9 months ago

You should now see these classifiers here, which means they're good to use: https://pypi.org/classifiers/