pypa / twine

Utilities for interacting with PyPI
https://twine.readthedocs.io/
Apache License 2.0
1.61k stars 308 forks source link

Py 3.13: Twine imports `cgi` that doesn't exist #1046

Closed arcivanov closed 9 months ago

arcivanov commented 9 months ago

Is there an existing issue for this?

What keywords did you use to search existing issues?

No response

Please describe why your using this option

  1. The template "Bug" is broken: https://github.com/pypa/twine/blob/main/.github/ISSUE_TEMPLATE/02_bug.yml

image

  1. Twine fails with Python 3.13 due to trying to import cgi
        error = cli.dispatch(sys.argv[1:])
                ~~~~~~~~~~~~^^^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/site-packages/twine/cli.py", line 121, in dispatch
        main = registered_commands[args.command].load()
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
      File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/site-packages/importlib_metadata/__init__.py", line 184, in load
        module = import_module(match.group('module'))
                 ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
      File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/importlib/__init__.py", line 88, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
               ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
      File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
      File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 1012, in exec_module
      File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
      File "/opt/hostedtoolcache/Python/3.13.0-alpha.3/x64/lib/python3.13/site-packages/twine/commands/check.py", line 16, in <module>
        import cgi

Anything else you'd like to mention?

No response

sigmavirus24 commented 9 months ago

See also #969