search

pypa / twine

Utilities for interacting with PyPI
https://twine.readthedocs.io/
Apache License 2.0
1.59k stars 305 forks source link

Tests on Main are failing #1120

Closed jaraco closed 2 months ago

jaraco commented 2 months ago

Is there an existing issue for this?

What keywords did you use to search existing issues?

No response

Please describe why your using this option

Scrolling back in the history of Actions, it appears the last time the Main tests passed was in this run, about 6 months ago.

Actually, that's not entirely true. There are a couple of tests that passed about 5 months ago, but with lots of intervening failures.

image

Probably we should stabilize the codebase and get tests passing again.

I haven't looked into why the tests are failing, but there appear to be multiple causes, as some tests fail based on the integration steps and others fail based on the tests steps.

Anything else you'd like to mention?

No response

jaraco commented 2 months ago

It seems that CI can be green again after the fix for #1116. But in https://github.com/pypa/twine/issues/1121#issuecomment-2187787859, sigmavirus24 complains that the integration tests are flaky. Is that the cause of all of the CI failures for the past 5 months?

jaraco commented 2 months ago

I've spot checked a few failures of Main in the past month or so, and the failures appear to either be failed integration tests or the failure brought about by pkginfo, so I'll repurpose this issue to address the integration tests.

jaraco commented 2 months ago

Aha. I see #684 is already filed to address flaky integration tests.