search

pypa / twine

Utilities for interacting with PyPI
https://twine.readthedocs.io/
Apache License 2.0
1.59k stars 305 forks source link

fix: use correct location for URL #1126

Closed henryiii closed 2 months ago

henryiii commented 2 months ago

Alternative to #1124, fixing the issue rather than hiding the error. Requires #1123.

jaraco commented 2 months ago

I'm pretty sure the assignment of __author__ is also broken, based on the reported DeprecationWarnings.

henryiii commented 2 months ago

Yes, I think you are right. These dunder attributes aren't a standard anyway (a failed standard, technically), I wonder if it would be fine to just remove them?

henryiii commented 2 months ago

"wheel" should also be removed from pyproject.toml.

henryiii commented 2 months ago

Setting the metaadata version too high is now a warning instead of an error; how should that be handled? Covert to error, or just test for the warning?

henryiii commented 2 months ago

Ahh, needs #1123. I can rebase on that.

henryiii commented 2 months ago

You won't actually be able to release without yanking 5.1.0, though, since https://github.com/pypa/twine/blob/6fbf880ee60915cf1666348c4bdd78a10415f2ac/.github/workflows/release.yml#L79 is broken due to twine being broken! :)

henryiii commented 2 months ago

Hmm, looks like it's pinned, not sure why https://github.com/pypa/gh-action-pypi-publish/issues/246 exists then.

jaraco commented 2 months ago

I've changed the base of the PR to target the branch for #1123 so that the diff is apparent. I expect GitHub to re-target main after #1123 is merged.

jaraco commented 2 months ago

A very similar patch was proposed in #1115. Perhaps we should accept that instead, since it was proposed first. Also, it re-uses the email module to parse the email field, which seems preferable.

JohnVillalovos commented 2 months ago

A very similar patch was proposed in #1115. Perhaps we should accept that instead, since it was proposed first. Also, it re-uses the email module to parse the email field, which seems preferable.

Makes sense. They went through all the effort 28 days ago to fix it...

henryiii commented 2 months ago

Okay, I'm going to close this to make sure that one is the one that goes in. I like the usage of the email module better too.