docs: ways to document TWINE_USERNAME ignored for pypi since 5.0 - Githubissues

pypa / twine

Utilities for interacting with PyPI

https://twine.readthedocs.io/

Apache License 2.0

1.61k stars 308 forks source link

docs: ways to document TWINE_USERNAME ignored for pypi since 5.0 #1133

Closed henryiii closed 3 months ago

henryiii commented 3 months ago

Is there an existing issue for this?

[X] I have searched the existing issues (open and closed), and could not find an existing issue

What keywords did you use to search existing issues?

twine_username

Please describe why your using this option

Someone reported that TWINE_USERNAME wasn't working, and we spent around an hour debugging it. Finally came across https://github.com/pypa/twine/blob/94f810c54c8bc9d418a9ed64890ca9fa4ec7b59f/twine/auth.py#L34-L39 - I should have remembered this, but https://blog.pypi.org/posts/2024-01-01-2fa-enforced/ was too far down on the page and there's no mention of this in the twine 5.0 changelog (other than a link to #1040, which still isn't clear in the title)

I think this could be improved, a few ideas:

Expand the details of this in the changelog entry for 5.0.0
Check to see if a username other than __token__ is set in this PyPI/TestPyPI branch, and issue a warning about requesting a username.
Maybe add a note in the CLI help for -u.

Anything else you'd like to mention?

Someone ran into this in https://github.com/pypa/twine/issues/1113

woodruffw commented 3 months ago

Sorry for the confusion this change caused! #1040 was my doing, so I'll take responsibility for improving the behavioral change documentation here.