Open wuch-g2v opened 10 months ago
At least one of the units needs to be updated for latest setuptools-scm
.
here is pytest output
PR welcome.
Sorry I'm only messenger ..
But you can now become so much more...
To be able form PR it is necessary to know about the code and intention of the developer who wrote that code. I'm not possessing such knowledge.
The developer who wrote the code might long ago moved to different projects, but the code should be self explaining so there shouldn't be any barriers for you to take a stab at it. I'll be able to provide feedback on your PR either way once it is in.
Again: to start work on that someone needs to identify is it tested code or test suite issue. I'm not able to do that. I'm only flagging the issue. If you are not able to solve that that is all what needs to be flagged. Maybe someone will do that but first it would be good to know is possible to reproduce what I'm able to observe ..
All these tests fail in assert not err
when setuptools-scm is installed. Up to setuptools-scm v7.1.0, the err
variable is an empty string but from v8.0.0 to v8.0.3 it is
'ERROR setuptools_scm._integration.setuptools pyproject.toml does not contain a tool.setuptools_scm section\nTraceback (most recent call last):\n ...'
and in v8.0.4 it is
'WARNING setuptools_scm._integration.setuptools pyproject.toml does not contain a tool.setuptools_scm section\nWARNING setuptools_scm._integration.setuptools pyproject.toml does not contain a tool.setuptools_scm section\n'
OK so it was possible to reproduce those fails (which is good π )
Does this need a fix? Since setuptools_scm
seems to not be in the list of virtualenv
βs dependencies anymore.
I guess the question is, why does the OP have setuptools_scm
active when the tests are run? Is setuptools_scm
changing the output merely by being installed? That seems like a bug in setuptools_scm
. The warning sounds like it's trying to alert people who have it installed but aren't configuring it via pyproject.toml
- maybe to help with transition from an older config method?
The easy fix seems to be "don't have setuptools_scm
installed in the environment you're running the virualenv tests in", or "get setuptools_scm
to remove the warning"? Or am I missing something here?
Does this need a fix? Since
setuptools_scm
seems to not be in the list ofvirtualenv
βs dependencies anymore.
But hatch-vcs has it, which is a build requirement for virtualenv. OP like many other distribution packagers run the unit tests in the same environment as they built the package.
But hatch-vcs has it, which is a build requirement for virtualenv. OP like many other distribution packagers run the unit tests in the same environment as they built the package.
You're right. I used tox
for the build, which installs build dependencies in a separate environment.
Issue
Looks like with 20.24.6 pytest is filing in four units Environment
Provide at least:
pip list
of the host python wherevirtualenv
is build:<.details>