pypa / virtualenv

Virtual Python Environment builder
https://virtualenv.pypa.io
MIT License
4.8k stars 1.03k forks source link

Fix test expectations for .gitignore comment created by Python 3.13+ venv #2672

Closed hroncok closed 9 months ago

hroncok commented 9 months ago

Since Python 3.13, the .gitignore file is created by venv: https://github.com/python/cpython/pull/108125

Fixes https://github.com/pypa/virtualenv/issues/2670

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

hroncok commented 9 months ago

I converted the PR to a draft to see if I could get Python 3.13 on the CI.

gaborbernat commented 9 months ago

I belive the CI will run with the main config because you don't have write access. However, you can enable GH actions for your fork at https://github.com/hroncok/virtualenv and we can use that.

hroncok commented 9 months ago

I converted the PR to a draft to see if I could get Python 3.13 on the CI.

Let's not. I'll open a separate one to see all the errors without fixes: https://github.com/pypa/virtualenv/pull/2673

gaborbernat commented 9 months ago

I belive the CI will run with the main config because you don't have write access. However, you can enable GH actions for your fork at hroncok/virtualenv and we can use that.

Until you do this I cannot validate that your changes are valid because it doesn't run your PRs CI.

hroncok commented 9 months ago

I can rebase this on https://github.com/pypa/virtualenv/pull/2673 to demonstrate the fix, but the CI will still fail due to the other issue.

hroncok commented 9 months ago

To avoid a chicken and egg problem, I decided to add everything at https://github.com/pypa/virtualenv/pull/2673