search

pypa / virtualenv

Virtual Python Environment builder
https://virtualenv.pypa.io
MIT License
4.8k stars 1.03k forks source link

Fix windows utf8 encoding issue #2687

Closed PzaThief closed 5 months ago

PzaThief commented 7 months ago

Batch and Powershell do not work properly if non-ASCII text (e.g. "аạąäàáą") is used in the folder name or prompt name. For Batch case, there is a codepage issue under the problem and cpython's venv has the solution already. And Powershell assumes Windows 1252 encoding when reading files without BOM. So I added Bom using utf-8-sig encoding.

Batch error screenshot (see broken prompt name after activate) Batch error screenshot

Powershell error screenshot Powershell error screenshot

PzaThief commented 5 months ago

Tests please.

Sorry for late. I fixed test failing now. could you check CI again?