Fix PATH-based Python discovery on Windows

pypa / virtualenv

Virtual Python Environment builder

https://virtualenv.pypa.io

MIT License

4.78k stars 1.02k forks source link

Fix PATH-based Python discovery on Windows #2712

Closed ofek closed 4 months ago

ofek commented 4 months ago

This PR:

Resolves #2711
Addresses another issue found during debugging which is that the PR that introduced the regression took out a check to make sure that executables exist before trying to gather data about the interpreter
Added an optimization so that the entire discovery process prevents duplicate interpreter calls rather than just the PATH fallback at the end

ofek commented 4 months ago

FYI macos-latest is having a staggered rollout to ARM and it looks like it happened here. Would you like me to downgrade the runner or drop 3.7 finally now?

gaborbernat commented 4 months ago

Sure 👍

ofek commented 4 months ago

Drop 3.7?

gaborbernat commented 4 months ago

Keep 3.7.

ofek commented 4 months ago

Any idea why that job timed out after 20 minutes?

ofek commented 4 months ago

oh thanks for restarting that!