limit filelock to highest compatible version - Githubissues

pypa / virtualenv

Virtual Python Environment builder

https://virtualenv.pypa.io

MIT License

4.78k stars 1.02k forks source link

limit filelock to highest compatible version #2736

Closed emmettbutler closed 2 months ago

emmettbutler commented 2 months ago

filelock 3.15.0 was just released and causes the following crash when used with the latest version of virtualenv

Traceback (most recent call last):
  File "/root/.pyenv/versions/3.10.11/lib/python3.10/site-packages/filelock/_api.py", line 365, in __del__
    self.release(force=True)
  File "/root/.pyenv/versions/3.10.11/lib/python3.10/site-packages/virtualenv/util/lock.py", line 34, in release
    with self.thread_safe:
AttributeError: '_CountedFileLock' object has no attribute 'thread_safe'

This change avoids depending on this new incompatible version of filelock.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

[x] ran the linter to address style issues (tox -e fix)
[x] wrote descriptive pull request text
[x] ensured there are test(s) validating the fix
[x] added news fragment in docs/changelog folder
[x] updated/extended the documentation

gaborbernat commented 2 months ago

Fixed via https://github.com/tox-dev/filelock/issues/337#issuecomment-2163685595