search

pyparsing / pyparsing

Python library for creating PEG parsers
MIT License
2.15k stars 276 forks source link

Whitespace changes for readability #523

Closed InSyncWithFoo closed 7 months ago

InSyncWithFoo commented 8 months ago

This PR is a part of #519.

Hopefully I'll be working on core.py tomorrow or so.

ptmcg commented 8 months ago

Are you running black on these changes? I expected black to take care of whitespace mods.

InSyncWithFoo commented 8 months ago

No, I haven't. Personally I have never used it since my code style (using many empty lines, as you can see) is quite different from PEP 8/black. I tried it just now and the result looks pretty much not my taste.

Of course, you can choose whether to accept this PR or not. I don't recommend running black on this since that would just result in an ugly mix of both.

ptmcg commented 7 months ago

Thanks for submitting, but when I run black, it will likely revert most of these changes.